This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Add token symbol images. #2207
Merged
Add token symbol images. #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairlighteth
commented
Jan 19, 2022
| background: grey; | ||
| background: ${({ symbol, theme }) => | ||
| `url(${ | ||
| symbol === 'GNO' ? LogoGNO : symbol === 'ETH' ? LogoETH : symbol === 'USDC' ? LogoUSDC : theme.blueShade3 |
There was a problem hiding this comment.
Function would likely be cleaner, but given this limited scope of 3 token symbols......
There was a problem hiding this comment.
Still don't know how to simplify this where I can use the prop symbol as the variable name instead. So that we could do: url(${symbol}.png.
Perhaps like props[symbol] => 'GNO' ?
There was a problem hiding this comment.
Just make a map that has token symbol as keys and logo as values
const TokenSymbolToLogoMap = {
GNO: GNOLogo,
// ...rest
}Ideally we have some enum of the claim tokens you can use as dynamic keys
|
fairlighteth
changed the base branch from
claim-styleImprove-12
to
claim-styleImprove-11
|
Great! |
anxolin
added a commit
to anxolin/cowswap
that referenced
this pull request
Apr 1, 2022
Add token symbol images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds token symbol images
ToDo notes:
.