Claim last investment page #2227
Conversation
|
|
Looks good. I enabled all investment options but have no balance. I guess it's to be expected to get this error, when wanting to execute: |
| `url(${ | ||
| symbol === 'GNO' ? LogoGNO : symbol === 'ETH' ? LogoETH : symbol === 'USDC' ? LogoUSDC : theme.blueShade3 | ||
| }) no-repeat center/contain`}; | ||
| background: ${({ symbol, theme }) => `url(${_getLogo(symbol) || theme.blueShade3}) no-repeat center/contain`}; |
There was a problem hiding this comment.
Nice! Thanks for doing this.
| <span> | ||
| <b>Investment amount:</b>{' '} | ||
| <i> | ||
| {formattedCost} {symbol} ({percentage}% of available investing opportunity) |
There was a problem hiding this comment.
@michelbio, should we style differently the non 100% cases?
not investing 100% is something that cannot be undone.
I would even omit the percentage if it's 100%.
This could be done in another PR
| () => | ||
| freeClaims.concat(selectedClaims).map((claim) => _enhancedUserClaimToClaimWithInvestment(claim, investFlowData)), | ||
| [freeClaims, investFlowData, selectedClaims] | ||
| ) |
There was a problem hiding this comment.
you don't need two useMemos right? the first one could already return allClaims. I say this cause we don't use freeClaims selectedClaims anywhere but in this memo
There was a problem hiding this comment.
I've split because as explained with comments in the code, one section is used for step 1 and 2 while other section is only for step 2.
I don't want to update the step 2 path unnecessarily while on step 1
|
small thing for a follow up, shouldn't we format using thousands?
I feel that should be our default everywhere |
|
I'd add somewhere a total of claimed tokens (airdrop and investment options) that a user will receive after a successful transaction. |
Summary
Wire up last investment step, the investment summary
To Test
Accounts