[CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) #2233

W3stside · 2022-01-20T14:46:02Z

Summary

Wires in the new useApproveCallbackFromClaim - which has been tweaked to better handle how the claim flow works.

Testing

Use an account that has GNO/USDC & NO APPROVALS
Using same account, approve GNO/USDC and note that in MM the approve amount is huge
reload app, see that it is approved
Using same connected account, hit "Change account" and paste an account with paid claims GNO/USDC (fresh address that doesn't have approvals)
See that tokens are approved because you are using the connected account from step 1 which is approved
ETH is already approved

github-actions · 2022-01-20T14:56:27Z

🔭 GP Swap: Gnosis Protocol v2 Swap UI

elena-zh · 2022-01-20T15:03:44Z

Works as described.
I was able to proceed with claiming in this PR

@nenadV91

… stuff also) (#2233) * move approve logic from Claim > InvestOption * helper utils * tweak claim approve hook * apply @nenadV91's suggested fix * path

@nenadV91

… stuff also) (#2233) * move approve logic from Claim > InvestOption * helper utils * tweak claim approve hook * apply @nenadV91's suggested fix * path

@nenadV91

) * mod the mod * edit the modded trade and claim approve hooks * edit places in app using new hook params * fix approve logic conditional * change logic * [CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) (#2233) * move approve logic from Claim > InvestOption * helper utils * tweak claim approve hook * apply @nenadV91's suggested fix * path * allow investmentAmount ro take maxCost * remove investmentAmount * && instead of || * tweak to approve logic * fix rebase error

W3stside added 5 commits January 20, 2022 14:44

move approve logic from Claim > InvestOption

b042b14

helper utils

b00c19b

tweak claim approve hook

7a99e64

apply @nenadV91's suggested fix

f530d2f

path

dbe4227

W3stside changed the title ~~Claim approve implement~~ [CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) Jan 20, 2022

W3stside requested review from a team January 20, 2022 14:50

W3stside merged commit 5a787bd into claim-approve-optional-param Jan 20, 2022

maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022

chore: update multicodec usage (#2233)

c2c7d87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) #2233

[CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) #2233

W3stside commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022

elena-zh commented Jan 20, 2022

[CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) #2233

[CLAIM - Approve] Wire new approve logic into app (fixes broken merge stuff also) #2233

Conversation

W3stside commented Jan 20, 2022 • edited Loading

Summary

Testing

github-actions bot commented Jan 20, 2022

elena-zh commented Jan 20, 2022

W3stside commented Jan 20, 2022 •

edited

Loading