Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Total vcow on investment summary #2237

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Conversation

alfetopito
Copy link
Contributor

Summary

Show total vCOW amount on investment summary page

Screen Shot 2022-01-20 at 11 24 19

To Test

  1. On claim page, pick a wallet that has at least 1 investment
  2. Proceed to the last step
  • Total amount on top should match the sum of all the investments + free claims displayed on the page

@alfetopito alfetopito self-assigned this Jan 20, 2022
@alfetopito alfetopito requested review from a team January 20, 2022 19:46
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Great changes!

@fairlighteth
Copy link
Contributor

Looks good! We could consider still showing the smaller top title, above the amount. Just like on the first page. Something like:

Total amount to claim

@alfetopito alfetopito force-pushed the total-vcow-on-investment-summary branch from e0318d6 to e749325 Compare January 21, 2022 15:21
@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 21, 2022
@alfetopito
Copy link
Contributor Author

Applied Michel's suggestion
Screen Shot 2022-01-21 at 07 21 12

@mergify mergify bot merged commit 7b5ed4f into develop Jan 21, 2022
@fairlighteth
Copy link
Contributor

@alfetopito Looks good!

@alfetopito alfetopito deleted the total-vcow-on-investment-summary branch January 21, 2022 15:45
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants