This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Add link read more in footer, and inform about changing networks #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
My first impression is, that the text link we use right below the primary button, is seen as a 'secondary' action. The 'Read more about vCOW' feels like it should be part of the description above instead. |
|
Links work for me! |
elena-zh
approved these changes
Jan 24, 2022
elena-zh
suggested changes
Jan 24, 2022
alfetopito
reviewed
Jan 24, 2022
| @@ -43,7 +43,7 @@ export default function CanUserClaimMessage({ hasClaims, isAirdropOnly, handleCh | |||
| <ButtonSecondary onClick={handleChangeAccount} padding="0"> | |||
| Try another account | |||
| </ButtonSecondary>{' '} | |||
| or <ExternalLink href={COW_LINKS.vCowPost}>read more about vCOW</ExternalLink> | |||
| or try in a different network. | |||
There was a problem hiding this comment.
Agree with Elena, show what's the current network being checked
Merged
|
Added the network name Also remove the duplicated link |
|
Please review in the consolidated version :) ...merging |
|
LGTM! |
|
Approved |
|
Looks good. Two comments:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
After
Add the read more link below the button:
also here:
Additionally, hint the user they might have a claiming available in another Network
To Test