-
Notifications
You must be signed in to change notification settings - Fork 55
[Claim] check other chains for claimable amts + click to change networks #2313
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like very much how this idea is implemented, two quick feedbacks:
-
It's telling me I have a claiming available in GC, but this is where i am and I don't see it.
-
It doesn't make sense to show you have a claiming in the network you are. I would exclude the current network from the message.
What about:
You ${hasClaim ? ' also' : '' } have available claims on ${otherNetworks}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit big too review the code. I realised some of the comments from my review are related to the change network hook, which i later realised is a copy pasta, so not your code.
Anyways, maybe this case we can change it, since we didn't do a mod, and we just duplicated the logic to own it.
In addition to @alfetopito comments above, I'd like to propose change text banner to 'This account has available claims in <>' due to 'You have..' sounds a bit illogical when check available claims on behalf of someone else. |
Some other issues: |
cc8d783
to
eae99c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great feature! works very well now.
I agree with all design suggestions. This PR is also big enough, should we merge and do a follow up?
Agree on merging to follow up. My feedback on @elena-zh 's points:
|
Will we address this? |
* check consumed claims using modded hooks * number > SupportedChainId
* use NotificationBanner instead of PhishAlert * styles
c28ba15
to
fe3c823
Compare
Summary
Shows claims in other chains and allows clicking chain name to change network
Closes #TBD
Add screenshots if applicable. Images are nice :)
What it looks like
Can click and change networks:
To Test
about
Background
Optional: Give background information for changes you've made, that might be difficult to explain via comments