Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Added copy button to claiming account #2317

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Copy button on claiming account
Screen Shot 2022-01-26 at 11 19 30

To Test

  1. Go to claim, check for one account
  • There should be a copy button next to the address in the top right

@alfetopito alfetopito self-assigned this Jan 26, 2022
@alfetopito alfetopito requested review from a team January 26, 2022 19:29
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@fairlighteth
Copy link
Contributor

Nice one. Only things I found:

  • We need some margin between 'copied' and the checkmark icon (on click)
  • On mobile it pushes the other element around
Screen.Recording.2022-01-26.at.21.26.19.mov

I say, low prio for now and I shall address these separately 👍🏼

@elena-zh
Copy link

Hey @alfetopito , works fine!
In addition to @biocom comment, I should state that 'Copied!' moves 'Change account' button outside of the screen area in real mobile devices (both in Android and iOS)

outside.mp4

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise approve!

@fairlighteth
Copy link
Contributor

Merging to see if I can address one of the style issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants