Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Resetting state on network change #2321

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Resetting state on network change #2321

merged 1 commit into from
Jan 27, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Fixes #2296

Resetting state on network change

To Test

  1. Connect with a wallet that has paid claims
  2. Select and move to approvals step or the next one
  3. Switch the network using either the switcher or the wallet
  • Claims should be refreshed and reset to initial claim page

@alfetopito alfetopito self-assigned this Jan 26, 2022
@alfetopito alfetopito requested review from a team January 26, 2022 22:27
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@alfetopito alfetopito mentioned this pull request Jan 26, 2022
Merged
@fairlighteth
Copy link
Contributor

Tested the flow and works 👍🏼

@elena-zh
Copy link

Hey @alfetopito , great job!

I'm not sure if it is a part of this PR or not, but I'd also navigate a user to the initial claim page when change networks on the Successful claim page.
Video: https://watch.screencastify.com/v/DmZ380si9QUJ0cJiftlA
Let me know please if you can fix it here, or I need to create a separate issue for this.
Thanks!

anxolin
anxolin approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

At first i was concerned if this might break use case of being in mainnet, seeing david's message about claiming in GC, clicking on change network, and loosing the info (cause of resetClaimUi )

But then is saw resetClaimUi doesn't remove the selection of your account, which is nice

@elena-zh
Copy link

Hey @alfetopito , great job!

I'm not sure if it is a part of this PR or not, but I'd also navigate a user to the initial claim page when change networks on the Successful claim page. Video: https://watch.screencastify.com/v/DmZ380si9QUJ0cJiftlA Let me know please if you can fix it here, or I need to create a separate issue for this. Thanks!

This issue was addressed in #2322 .
Approved!

@alfetopito alfetopito merged commit 17a76f2 into release/1.10 Jan 27, 2022
@alfetopito alfetopito deleted the 2296/broken-state-on-network-change branch January 27, 2022 15:43
ramirotw pushed a commit that referenced this pull request Feb 18, 2022
@carlosdp
feat: add @davatar/react for robust avatar support (#2321)
cc8c571 
* add @davatar/react for robust avatar support

* remove @metamask/jazzicon, unused

* move @davatar/react to devDependencies

* pin exact version for @davatar/react
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@W3stside W3stside W3stside approved these changes

@fairlighteth fairlighteth fairlighteth approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alfetopito @fairlighteth @elena-zh @anxolin @W3stside