Fix change or disconnect wallet after claim confirm

[nenadV91]

Summary

Fixes #2251

[W3stside]

shouldn't the useEffect trigger on account change? why is previousAccount needed? I would think

useEffect(() => {
    if (!account || claimStatus === ClaimStatus.CONFIRMED) {
...

should work, it doesn't?

[nenadV91]

Since claimStatus is dependency this (!account || claimStatus === ClaimStatus.CONFIRMED) would activate instantly when the status becomes confirmed and you would not see claim success view at all. So instead this account !== previousAccount && claimStatus === ClaimStatus.CONFIRMED this will only activate when the account changes and the claim is confirmed.

[github-actions]

• 🔭 GP Swap: CoW Protocol v2 Swap UI

[alfetopito]

I thought this was fixed in #2322, no?

[nenadV91]

@alfetopito Just checked on release branch, looks like its still there when you disconnect the wallet after claim is confirmed you see this

In that PR it doesn't reset the activeClaimedAccount because of !isSearchUsed on this line

cowswap/src/custom/pages/Claim/index.tsx

Line 171 in de537f6

if (!isSearchUsed && account) {

[elena-zh]

Hey @nenadV91 , changes LGTM!
However, would it be better to navigate a user to this screen when change accounts

instead of this one?

The same is for the flow when open another page and then go back to the Claim page.

[nenadV91]

@elena-zh Should be all there now.

[elena-zh]

Great!