Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim for another account #2358

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Claim for another account #2358

merged 1 commit into from
Jan 31, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 31, 2022

Summary

This PR reiterates on https://github.com/gnosis/cowswap/pull/2355/files to replace the "Go back" link for a "Claim for another account" one in case the tx succeds (based on this comment https://github.com/gnosis/cowswap/pull/2355/files#r795621057)

Result:
image

When clicked, you get to this screen:
image

To Test

  1. Test to do any kind of claiming (which succeeds)
  2. Test the new link
  3. Test the case where the transaction fails

@anxolin anxolin changed the base branch from develop to 2082/no-success-on-failure January 31, 2022 13:30
@anxolin anxolin requested review from a team January 31, 2022 13:30
@anxolin anxolin changed the base branch from 2082/no-success-on-failure to develop January 31, 2022 13:34
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin
Copy link
Contributor Author

anxolin commented Jan 31, 2022

Merging to consolidate. Let me know if there's any comments

@anxolin anxolin merged commit 8d23af2 into develop Jan 31, 2022
@elena-zh
Copy link

LGTM

@alfetopito alfetopito deleted the claim-for-another-account branch January 31, 2022 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants