Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Menu: view all orders position #2399

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Menu: view all orders position #2399

merged 5 commits into from
Feb 8, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Feb 7, 2022 •
edited
Loading

Summary

Fixes #2149
image

To Test

  1. Open the [...] Menu and see the "View all order" link position.
    (this link appears to a connected user who has done a trade in the platform.)

Extra:

  • External link arrow added on activity modal:
    image
  • Icon style (Before -> After):
    image image

@alongoni alongoni self-assigned this Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022 •
edited
Loading

CLA Assistant Lite All Contributors have signed the CLA.

@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team Enhancement New feature or request labels Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Feb 8, 2022

Hey @alongoni , great changes!
The only thing is that if we are adding an external link arrow to the 'View all orders' action, it would be nice to add it to the bottom link in the Activity modal as well
image

@alongoni
Copy link
Contributor Author

alongoni commented Feb 8, 2022

@elena-zh Done. Thanks!
image

@elena-zh
Copy link

elena-zh commented Feb 8, 2022

@alongoni , seems that the commit is failed

matextrem
matextrem approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@matextrem matextrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Feb 8, 2022
@mergify mergify bot merged commit 1e1b409 into develop Feb 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@matextrem matextrem matextrem approved these changes

@elena-zh elena-zh Awaiting requested review from elena-zh

@henrypalacios henrypalacios Awaiting requested review from henrypalacios

Assignees

@alongoni alongoni

Labels
app:CowSwap CowSwap app Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Enhancement New feature or request Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu: move 'View all orders' upper in the menu
4 participants
@alongoni @elena-zh @alfetopito @matextrem