This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
1867 - Add network if nonexistent #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
W3stside
commented
Feb 15, 2022
| }) | ||
| } catch (error) { | ||
| console.error('error adding eth network: ', chainId, info, error) | ||
| throw new Error(error?.message) |
There was a problem hiding this comment.
this is the only MOD, L34.
open to not using a new error object, just needs to be rethrown.
W3stside
commented
Feb 15, 2022
| if (error.code === 4902 && chainId !== undefined) { | ||
| const info = CHAIN_INFO[chainId] | ||
|
|
||
| // MOD - need to handle these errors, else loops |
There was a problem hiding this comment.
L33 - 42 (try/catch) block is the MOD. Without proper error handling this loops
|
Hey @W3stside , great changes! |
elena-zh
approved these changes
Feb 15, 2022
alfetopito
approved these changes
Feb 15, 2022
My post vacay energy helped me find it 👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️👁️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1867
Summary
Adds correct network adding logic when chain NOT in MM, fixes loop error and chain info object type (uni related)
Screenies
TESTING