-
Notifications
You must be signed in to change notification settings - Fork 55
[CoW Subsidy] Connect modal and add comp to swap mod #2551
Conversation
prob with builds here and #2549 |
Seems that the build has failed. |
b5081b8
to
2cd478f
Compare
|
Hey @W3stside ! Nice changes! And here are my early issues:
Thanks! |
@gnosis/gp-frontend thoughts? i think we should always show. 0 vcow? show. Not connected? Show @fairlighteth will handle this stuff, could we make a note of it somewhere? thanks! @gnosis/gp-frontend I think we should show it even then @fairlighteth also mentioned this, good point. Could we add this to the style fixes notes?
|
@elena-zh merging as consensus on slack for the showing was reached. Could you create an issue for @fairlighteth to style the other issues you found? thanks! |
anyone else from @gnosis/gp-frontend with concerns? as this is a waterfall and @elena-zh already documented issues i will merge this, please post review if u need or just wait for consolidation |
Hey @W3stside , I have created separate issues #2560 and #2561 for the UI cases I reported above. Let me know please If I need to create a separate issue for this. |
I would show always. |
@W3stside this line doesn't make too much sense to me. >0 u get 0? |
* CoW subsidy modal + sub components * force commit * [CoW Subsidy] Connect modal and add comp to swap mod (#2551) * revert !account test check * add cow subsidy modal type to state * add component to swapmod * use AutoRow * [Cow Subsidy] - Get user's (v)COW balance fn + tests (#2557) * create discount utl fn & tests * move constants to file closer to subsidy code * minor changes to SubsidyTable * fix broken path * PR comments - ease up logic and data * [CoW Subsidy] - Highlight current subsidy relative to CoW balance and show correct discount on SwapMod (#2558) * add selected tier styling to table * change return of util * pass tier (mock) to modal * more serious hook impl. * change type to subsidy and use hook * fix test * use atom units for better math - simpler for..of loop - format table units down * better tests and fix logic * type change and minor logic lean * fix test tier with lt change * lt inclusive in loop * fix typo * dont show empty container * hide balance on !account
Summary
Part of and #2549
Connects more data to modal and adds Fee discount comp to swap mod. Clickable to open