Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Added swapAll abi #2576

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Added swapAll abi #2576

merged 1 commit into from
Mar 23, 2022

Conversation

nenadV91
Copy link
Contributor

Summary

  • adds swapAll abi

@nenadV91 nenadV91 requested a review from a team March 22, 2022 19:32
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@nenadV91 nenadV91 added the RELEASE Included in the release that is being closed label Mar 22, 2022
@W3stside W3stside merged commit c31d925 into convert-vcow-with-hooks Mar 23, 2022
@W3stside W3stside deleted the convert-vcow-swap-1 branch March 23, 2022 09:18
anxolin
anxolin reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Very nice you did this one independently, however the changes are also here #2577
So we need to review it twice

@nenadV91
Copy link
Contributor Author

That convert-vcow-swap-2 branch was pointing to this one so these changes weren't included in that #2577 PR changed files before until this branch got merged.

@nenadV91
Copy link
Contributor Author

The idea was to merge convert-vcow-swap-2 into this one first

nenadV91 added a commit that referenced this pull request Mar 23, 2022
@nenadV91 @fairlighteth
Show real vCow and Cow data on profile page (#2568)
1e02a05 
* Profile page: Add vCOW swap feature cards (#2564)

* Style vCOW swap cards.

* Style vCOW swap cards. (#2565)

* Add governance card banner. (#2566)

* Add governance card banner.

* Governance banner update styles.

* Make question icon use dynamic dark/light mode colors.

* Center content properly cross devices.

* Dummy values.

* Disable unused vars

* Cleanup obsolete color

* Connect UI and vCow data

* Added PR changes

* Remove some previous change

* Added swapAll abi (#2576)

Co-authored-by: fairlight <[email protected]>
anxolin pushed a commit to anxolin/cowswap that referenced this pull request Apr 1, 2022
@nenadV91
Added swapAll abi (gnosis/cowswap#2576)
1125ce3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nenadV91 @alfetopito @anxolin @W3stside