Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

2571/full amounts cow profile #2584

Merged
merged 1 commit into from
Mar 24, 2022
Merged

2571/full amounts cow profile #2584

merged 1 commit into from
Mar 24, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Fixes #2571

Showing max value on hover for vcow/cow amounts on profile

Screen Shot 2022-03-24 at 09 08 53

To Test

  1. Go to profile page
  2. Change your locale
  • Amounts should be shown locale formatted
  1. Hover over vCOW/COW amounts
  • You should see the full amount in a title tooltip

Note: As with other title tootips, it does not work on mobile.

@alfetopito alfetopito requested review from a team March 24, 2022 16:13
@alfetopito alfetopito self-assigned this Mar 24, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

fairlighteth
fairlighteth approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@fairlighteth fairlighteth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏼

@alfetopito alfetopito merged commit 82ed76c into release/1.12.0 Mar 24, 2022
@alfetopito alfetopito deleted the 2571/full-amounts-cow-profile branch March 24, 2022 22:10
@elena-zh
Copy link

Changes LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@fairlighteth fairlighteth fairlighteth approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfetopito @elena-zh @anxolin @fairlighteth