This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Improve timeout util #1645
Merged
Improve timeout util #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W3stside
reviewed
Nov 30, 2020
W3stside
reviewed
Nov 30, 2020
| export function timeout<T>(params: TimeoutParams<T>): Promise<T> { | ||
| export function timeout(params: TimeoutParams<undefined>): Promise<never> // never means function throws | ||
| export function timeout<T>(params: TimeoutParams<T extends undefined ? never : T>): Promise<T> | ||
| export async function timeout<T>(params: TimeoutParams<T>): Promise<T | never> { |
There was a problem hiding this comment.
this should be renamed to promisedTimeout or sth, to indiciate it is awaitable in nature or actually i dont care
There was a problem hiding this comment.
hm, I also don't really care
W3stside
reviewed
Nov 30, 2020
|
ah ok thought it was a commented piece of code didn't really read it all
haha
|
W3stside
approved these changes
Nov 30, 2020
Velenir
added a commit
that referenced
this pull request
Nov 30, 2020
* Add timeout for fetching tokens * Improve timeout util (#1645) * simplify type without casting * default delay() return to void * simplify timeout function logic * improve timeout types * use new timeout with automatic rejected Promise detection * construct cacheKey once only * throw proper Error Co-authored-by: Velenir <[email protected]>
|
Cool, TS 🧙♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeoutfunction body to reuse already availableutlils/delayYou can see the usefulness of
Promise<never>here