Expose more DeployablePredictionAgent.get_markets args as properties

[evangriffiths]

No functional changes. It just enables an agent that bets on the newest markets, created after a certain date

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the DeployablePredictionAgent and DeployableTraderAgent classes within the prediction_market_agent_tooling/deploy/agent.py file. New attributes and parameters were introduced to enhance functionality, including filtering capabilities for market creation dates and conditional logic for trade execution and storage. The get_markets method in DeployablePredictionAgent was updated to utilize these new attributes, while the constructor of DeployableTraderAgent was modified to include new parameters for managing trade behavior.

Changes

File Path	Change Summary
prediction_market_agent_tooling/deploy/agent.py	- Added attributes trade_on_markets_created_after and get_markets_sort_by in DeployablePredictionAgent. - Updated get_markets method to include created_after parameter. - Modified DeployableTraderAgent constructor to add store_trades and place_trades parameters. - Updated process_market and after_process_market methods for conditional trade execution and storage based on new parameters.

Possibly related PRs

• 383 move rebalancing logic involving previous positions to strategy #387: This PR modifies the process_market method in agent.py, which is also a focus of the main PR, enhancing the trade execution logic and logging.
• Added PR comments hotfix | bumped version #392: Introduces a new method build_trades in agent.py, which is related to the changes in the main PR that also involve modifications to trade processing in the DeployableTraderAgent.
• Optionally filter out invalid markets #482: Adds a new attribute allow_invalid_questions in DeployableTraderAgent, which is relevant to the changes in the main PR that involve the DeployableTraderAgent class.
• Split DeployableTraderAgent into DeployablePredictionAgent #525: This PR involves significant changes to the DeployableTraderAgent, including renaming and restructuring, which directly relates to the changes made in the main PR regarding the DeployablePredictionAgent and DeployableTraderAgent classes.
• Allow for different configurations of DeployablePredictionAgent.same_market_trade_interval #531: Modifies the same_market_trade_interval in DeployablePredictionAgent, which is relevant to the changes in the main PR that enhance the functionality of the DeployablePredictionAgent.

Suggested reviewers

• kongzii

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kongzii]

Could you unify this, please:

n_markets_to_fetch is currently taken from the class' variable, get_markets_sort_by is defined as class' variable but it's used from this function arguments instead, and filter_by is only in this function arguments

[evangriffiths]

Oops fixed. Have left filter_by as hard-coded FilterBy.OPEN (since there's not a use-case atm for having a different value)