Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/gnosis neth #11

Merged
merged 89 commits into from
Jul 18, 2023
Merged

feat/gnosis neth #11

merged 89 commits into from
Jul 18, 2023

Conversation

4rgon4ut
Copy link

@4rgon4ut 4rgon4ut commented Jul 17, 2023 •
edited
Loading

This PR addresses implementation of Gnosis chain support for Nethermind client along with withdrawals test specifications.

Content:

  • Added support for Gnosis chain using Nethermind
  • Support for Withdrawals specs on Gnosis pull strategy
  • Remove no supported clients on Gnosis
  • Upgrade genesis load for clients

stdevMac and others added 30 commits April 5, 2023 04:31
@stdevMac
feat: add debug.dockerfile for withdrawals
3b4ac1f
@stdevMac
fix:docker problem
24c547a
@marioevz
simulators/ethereum/engine: send eth_ requests to port 8545 (ethere…
0f237de 
…um#752)

simulators/ethereum/engine: send `eth_` requests to 8545
@marioevz
clients/ethereumjs: Update branch (ethereum#753)
ed1e5e7 
* clients/ethereumjs: Change git branch

* clients/ethereumjs: Fix bash script issues
@marioevz
simulators/ethereum/engine: node: unsubscribe from events
aa696f6
@marioevz
simulators/ethereum/engine: clmock: add extra logs
ed3f6a1
@marioevz
simulators/ethereum/engine: correctly stop secondary clients
f2c72be
@stdevMac
feat: change mainnet to gnosis on hive role for some clients
ed31f50
@stdevMac
feat: add a override docker image flag to hive binary
95fb52e
@stdevMac
feat: add debug dockerfile option
9a01ea9
@stdevMac
feat: run go fmt in the whole project
a25ca43
@stdevMac
feat: add debug dockerfile option for ethereum/engine test suite usin…
a1dfaae 
…g a dockerfile
@marioevz
simulators/eth2/common: create client interfaces, update mock builder (…
28a27c9 
…ethereum#738)

* simulators/eth2/common: refactor clients

* simulators/eth2/engine: fixes due to refactor

* simulators/eth2/common: builder: invalidate payloads

* simulators/eth2/common: builder readme

* simulators/eth2/common: builder: add option to build a payload on an outdated version

* simulators/eth2/withdrawals: add invalid built payload version test

* simulators/eth2/common: builder: remove check to build invalid payload

* simulators/eth2/withdrawals: Fix check

* simulators/eth2/withdrawals: test case validation

* simulators/eth2/common: builder: fix invalidation

* simulators/eth2/withdrawals: fix verifications again
@marioevz
simulators/ethereum/pyspec: Comment Dockerfile to run local fixtures (e…
8a4ef3d 
…thereum#755)

simulators/ethereum/pyspec: Add Dockerfile comment to run locally generated fixtures
@gfukushima
clients/besu: add --data-storage-format=BONSAI (ethereum#758)
17a79c3
@marioevz
simulators/ethereum/engine: Unique Payload ID Tests (ethereum#757)
7f904b2 
* simulators/ethereum/engine: expose generic fcu, np

* simulators/ethereum/engine: Unique payload id test

* simulators/ethereum/engine: Add payload id test
@stdevMac
fix: update nethermind client building process
ad74a67
@stdevMac
feat: add mechanism to load chainspec for nethermind
f719075
@stdevMac
fix: update go.work.sum
e4d4bd2
@stdevMac
fix: update tests to run withdrawals on gnosis
61bbbe9
@stdevMac
feat: solve issue on the ttd interaction
d082831
@stdevMac
feat: add interaction for withdrawal contract
703d297
@stdevMac
add more time to wait for chain
32d9ac1
@stdevMac
fix: withdrawals not happening
89e47aa
@stdevMac
fix: check withdrawals balance working
c84f5b6
@stdevMac
feat: vendor engine dockerfile
20f3bc9
@stdevMac
feat: make debug.dockerfile not hardcoded
b2c8dde
@stdevMac
fix: add base for withdrawals sync test
3008a2e
@stdevMac
fix: working withdrawals sync test
2aff1d2
@stdevMac
fix: missing )
5225d91
4rgon4ut and others added 13 commits July 2, 2023 21:57
@4rgon4ut 4rgon4ut requested a review from stdevMac July 17, 2023 16:04
@4rgon4ut 4rgon4ut marked this pull request as ready for review July 17, 2023 16:06
4rgon4ut
4rgon4ut commented Jul 17, 2023
View reviewed changes
Copy link
Author

@4rgon4ut 4rgon4ut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdevMac LGTM!
Dropped down several minor optionals && simplifications.

internal/libdocker/builder.go Outdated Show resolved Hide resolved
internal/libdocker/builder.go Outdated Show resolved Hide resolved
internal/libdocker/container.go Show resolved Hide resolved
simulators/eth2/common/builder/mock/mock_builder.go Outdated Show resolved Hide resolved
simulators/eth2/common/builder/mock/mock_builder.go Outdated Show resolved Hide resolved
simulators/eth2/common/builder/mock/options.go Outdated Show resolved Hide resolved
simulators/eth2/common/clients/beacon.go Outdated Show resolved Hide resolved
simulators/eth2/common/clients/beacon.go Outdated Show resolved Hide resolved
simulators/eth2/common/clients/execution.go Outdated Show resolved Hide resolved
stdevMac and others added 11 commits July 18, 2023 12:41
@stdevMac @4rgon4ut
Update internal/libdocker/builder.go
da28911 
Co-authored-by: 4rgon4ut <[email protected]>
@stdevMac @4rgon4ut
Update simulators/eth2/common/builder/mock/mock_builder.go
2640c0a 
Co-authored-by: 4rgon4ut <[email protected]>
@stdevMac @4rgon4ut
Update simulators/eth2/common/builder/mock/mock_builder.go
017a1e2 
Co-authored-by: 4rgon4ut <[email protected]>
@stdevMac
[fix] take comments on PR
020f4dc
@stdevMac
Merge branch 'feat/gnosis-neth' of https://github.com/gnosischain/hive …
ca82552 
…into feat/gnosis-neth
@4rgon4ut
Update simulators/eth2/common/clients/beacon.go
e4779ff
@4rgon4ut
Update simulators/eth2/common/builder/mock/options.go
619a1ac
@4rgon4ut
Update simulators/eth2/common/clients/beacon.go
525ddf5
@4rgon4ut
Update simulators/eth2/common/clients/execution.go
8ef8f62
@4rgon4ut
chore(libdocker): logging instead of printing
799f5f0
@stdevMac
Merge branch 'feat/gnosis-neth' of https://github.com/gnosischain/hive …
7ed4802 
…into feat/gnosis-neth
@stdevMac stdevMac merged commit bebf58c into master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdevMac stdevMac stdevMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4rgon4ut @stdevMac @marioevz @gfukushima