Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route transactions through avatar Safe in simulation #78

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Conversation

jfschwarz
Copy link
Collaborator

So far we simulated transaction using the avatar Safe as sender (transaction from field). This caused issues in cases where called contracts used something like msg.sender.transfer(value). (Reason is that a transfer invokes the recipient contract\s fallback/receive hook with a gas stipend of 2300, which is insufficient for a cold safe proxy.)

From now on we simulate through the avatar Safe's execTransactionThroughModule or execTransaction (for direct exec without mod) function. For the latter case we need to adjust the signature threshold in the simulation fork.

Another unrelated changed introduces in the PR is that we switched from Blockscout to Gnosisscan as the block explorer for Gnosis.

@jfschwarz jfschwarz merged commit 305f555 into main Nov 13, 2023
1 of 2 checks passed
@jfschwarz jfschwarz deleted the fix-rocketpool branch November 13, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant