Connect via Safe Apps SDK #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an apps supports being run as a Safe app (uses Safe Apps SDK), Pilot will now connect to it that way. This connection will happen instantly (the user does not have to click through a wallet modal). Also some apps will adjust their transaction flows for smart account if they detect a Safe wallet.
In order to get this work reliably we need to make sure we have a provider ready before connecting to the Safe app. This is achieved by using a static JSON RPC provider rather than always going through the user's wallet (which might not be ready yet) as we used to.
Follow-up tasks, that we should tackle in subsequent PRs: