Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mentions on text renderer" #111

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Jul 1, 2024

feat: Add mentions on text renderer

@jefft0
Copy link
Contributor

jefft0 commented Jul 1, 2024

Clicking a mention in the main Feed screen works, but it doesn't work in the screen for another user's profile.

@jefft0
Copy link
Contributor

jefft0 commented Jul 1, 2024

If a message mentions a non-existing user like @badname then it shows "Profile loading" forever. (Need to check if the username actually exists before trying to open its screen.)

Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators.

Signed-off-by: Iuri Pereira <[email protected]>
@iuricmp iuricmp merged commit 88e48fa into gnoverse:main Jul 2, 2024
@iuricmp iuricmp deleted the feat/mentions branch July 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants