Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix user name display in follows-item #89

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Jun 6, 2024

This pull request fixes the issue with the user name display in the follows-item component. Previously, the user name was not being displayed correctly.

This PR updates the code to correctly enrich the data and display the user name by accessing the user.name property instead of the name property.

@iuricmp iuricmp requested a review from D4ryl00 June 6, 2024 10:12
@iuricmp
Copy link
Contributor Author

iuricmp commented Jun 6, 2024

Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3,7 +3,7 @@
"name": "dsocial",
"slug": "dsocial",
"platforms": ["ios", "android"],
"version": "1.0.2",
"version": "1.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version number is not used by semantic release. Instead, it's used when you compile the app to release on stores. We may automatize the process to increment the version.

@iuricmp iuricmp merged commit 1079c10 into gnoverse:main Jun 6, 2024
@iuricmp iuricmp deleted the fix/display-username-follow-list branch June 6, 2024 10:53
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants