Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access log Implementation #72

Merged
merged 8 commits into from
Jun 17, 2017

Conversation

adelowo
Copy link
Contributor

@adelowo adelowo commented Jun 16, 2017

Implementation of #69 feature.

@codecov
Copy link

codecov bot commented Jun 16, 2017

Codecov Report

Merging #72 into v0-unstable will increase coverage by 0.16%.
The diff coverage is 82.65%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0-unstable      #72      +/-   ##
===============================================
+ Coverage        83.53%   83.69%   +0.16%     
===============================================
  Files               17       18       +1     
  Lines             1518     1613      +95     
===============================================
+ Hits              1268     1350      +82     
- Misses             185      190       +5     
- Partials            65       73       +8
Impacted Files Coverage Δ
aah.go 70.8% <0%> (-1.05%) ⬇️
engine.go 88.66% <100%> (+2.95%) ⬆️
context.go 100% <100%> (ø) ⬆️
access_log.go 80.76% <80.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdc668...3b0b036. Read the comment docs.

@jeevatkm
Copy link
Member

Nice work, can you please add test case for initRequestAccessLog method? This PR is feature getting added to the framework not a fix.

@jeevatkm jeevatkm mentioned this pull request Jun 16, 2017
3 tasks
@adelowo
Copy link
Contributor Author

adelowo commented Jun 16, 2017

Sure, I can .. I already squashed this new test commit with the previous one

@adelowo adelowo force-pushed the request_access_log_non_blocking branch from 8f327ef to 95810ca Compare June 16, 2017 05:19
@adelowo adelowo force-pushed the request_access_log_non_blocking branch from 95810ca to 5223ca5 Compare June 16, 2017 05:42
@adelowo
Copy link
Contributor Author

adelowo commented Jun 17, 2017

HI @jeevatkm, what is the state of this PR

@jeevatkm
Copy link
Member

This is ready to be merged, just I need to do my part.

@jeevatkm jeevatkm merged commit 747a91e into go-aah:v0-unstable Jun 17, 2017
@adelowo adelowo deleted the request_access_log_non_blocking branch June 18, 2017 02:43
@adelowo
Copy link
Contributor Author

adelowo commented Jun 18, 2017

Thanks a lot

@jeevatkm
Copy link
Member

you're welcome.

@jeevatkm jeevatkm modified the milestone: v0.7 Milestone Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants