Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez committed Jul 25, 2023
1 parent a6d00c4 commit 812b941
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ require (
github.com/akamai/AkamaiOPEN-edgegrid-golang v1.2.2
github.com/aliyun/alibaba-cloud-sdk-go v1.61.1755
github.com/aws/aws-sdk-go v1.39.0
github.com/aws/aws-sdk-go-v2 v1.19.0
github.com/aws/aws-sdk-go-v2/config v1.18.28
github.com/aws/aws-sdk-go-v2/service/s3 v1.37.0
github.com/cenkalti/backoff/v4 v4.2.1
Expand Down Expand Up @@ -91,7 +92,6 @@ require (
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.0.0 // indirect
github.com/andres-erbsen/clock v0.0.0-20160526145045-9e14626cd129 // indirect
github.com/aws/aws-sdk-go-v2 v1.19.0 // indirect
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10 // indirect
github.com/aws/aws-sdk-go-v2/credentials v1.13.27 // indirect
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.5 // indirect
Expand Down
11 changes: 5 additions & 6 deletions providers/http/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"fmt"
"strings"

"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/service/s3"
"github.com/go-acme/lego/v4/challenge/http01"
Expand Down Expand Up @@ -46,8 +47,8 @@ func (s *HTTPProvider) Present(domain, token, keyAuth string) error {

params := &s3.PutObjectInput{
ACL: "public-read",
Bucket: pointer(s.bucket),
Key: pointer(strings.Trim(http01.ChallengePath(token), "/")),
Bucket: aws.String(s.bucket),
Key: aws.String(strings.Trim(http01.ChallengePath(token), "/")),
Body: bytes.NewReader([]byte(keyAuth)),
}

Expand All @@ -63,8 +64,8 @@ func (s *HTTPProvider) CleanUp(domain, token, keyAuth string) error {
ctx := context.Background()

params := &s3.DeleteObjectInput{
Bucket: pointer(s.bucket),
Key: pointer(strings.Trim(http01.ChallengePath(token), "/")),
Bucket: aws.String(s.bucket),
Key: aws.String(strings.Trim(http01.ChallengePath(token), "/")),
}

_, err := s.client.DeleteObject(ctx, params)
Expand All @@ -74,5 +75,3 @@ func (s *HTTPProvider) CleanUp(domain, token, keyAuth string) error {

return nil
}

func pointer[T string | int | int32 | int64](v T) *T { return &v }

0 comments on commit 812b941

Please sign in to comment.