Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rackspace: change zone ID to string #1508

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

chrishepner
Copy link
Contributor

Attempting a DNS challenge request with the Rackspace provider fails with an error in the following form:

2021/10/11 21:07:31 Could not obtain certificates:
        error: one or more domains had a problem:
[example.com] [example.com] acme: error presenting token: rackspace: json: cannot unmarshal string into Go struct field HostedZone.domains.id of type int

Querying https://dns.api.rackspacecloud.com/v1.0/account/domains?name=example.com shows that the domains.id field is now being returned as a string, rather than an int:

{"totalEntries":1,"domains":[{"id":"123456", ...}]}

This commit accordingly changes HostedZone and depending code to expect a string rather than an int.

@ldez
Copy link
Member

ldez commented Oct 12, 2021

Hello,

the documentation seems to say the opposite:
https://docs.rackspace.com/docs/cloud-dns/v1/api-reference/domains#list-domains-by-name

Status: 200 OK
Date: Thu, 28 Jul 2011 21:54:21 GMT
X-API-VERSION: 1.0.17
Content-Type: application/json
Content-Length: 202

{
  "domains" : [ {
    "name" : "region2.example.net",
    "id" : 2725352,
    "updated" : "2011-06-23T20:21:06.000+0000",
    "created" : "2011-06-23T19:24:27.000+0000"
  } ],
  "totalEntries" : 114
}

@ldez
Copy link
Member

ldez commented Oct 12, 2021

But the API documentation was not updated for 5 years:
https://github.com/rackerlabs/docs-cloud-dns/tree/master/api-docs/v1/api-reference/methods

🤔 maybe they changed their API and forget to update the documentation...

@ldez
Copy link
Member

ldez commented Oct 12, 2021

As I don't have a Rackspace account, I will trust you and hope that they will not revert this change.

@ldez ldez self-requested a review October 12, 2021 22:50
@ldez ldez changed the title fix: Change Rackspace zone ID to string rackspace: change zone ID to string Oct 12, 2021
@ldez ldez modified the milestones: v4.6, v4.5 Oct 18, 2021
@ldez ldez merged commit 88f62f1 into go-acme:master Oct 18, 2021
@robshep
Copy link

robshep commented Dec 12, 2021

I queried this with Rackspace.

"In late September/early October our DNS team had pushed out an update that changes any newly added domains to use a new alphanumeric string instead of the shorter integer. This is not a change we can roll back as these are the new style of UUID that the DNS API will be using going forward. As of yet the documentation does not reflect this but we are hoping to get it updated in the near future. I have created an internal report to help push this along."

@hannesdejager
Copy link

This seems to be documented here.

When will a release with this fix be forthcoming? I'm using Traefik thats using Lego and I'm a bit stuck with this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants