Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/renew: skip random sleep if stdout is a terminal #1659

Merged
merged 2 commits into from
Jun 17, 2022
Merged

cli/renew: skip random sleep if stdout is a terminal #1659

merged 2 commits into from
Jun 17, 2022

Conversation

dmke
Copy link
Member

@dmke dmke commented Jun 17, 2022

This aligns our behaviour with that of certbot.

@dmke dmke requested a review from ldez June 17, 2022 08:18
@ldez ldez added this to the v4.8 milestone Jun 17, 2022
ldez
ldez approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 3e9e6ac into go-acme:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/cli enhancement
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@dmke @ldez