Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredns: update docs #1988

Merged
merged 5 commits into from
Aug 11, 2023
Merged

azuredns: update docs #1988

merged 5 commits into from
Aug 11, 2023

Conversation

jlaundry
Copy link
Contributor

  • Clarify that specifying the target DNS zone's Tenant ID, Subscription ID, and Resource Group Name is required to use this provider with Managed Identities.
  • Provide an example of how to set permissions on a DNS Zone so that a Managed Identity can request a certificate.
  • Provide a hint for people trying to use Azure Arc's Managed Identity, that they may need to set special environment variables.

Pinging @pchanvallon for a review (and thanks for your efforts building this provider!)

@ldez
Copy link
Member

ldez commented Aug 11, 2023

Hello,

this file is generated:

<!-- THIS DOCUMENTATION IS AUTO-GENERATED. PLEASE DO NOT EDIT. -->
<!-- providers/dns/azuredns/azuredns.toml -->
<!-- THIS DOCUMENTATION IS AUTO-GENERATED. PLEASE DO NOT EDIT. -->

Could you update the source file: https://github.com/go-acme/lego/blob/master/providers/dns/azuredns/azuredns.toml

@ldez ldez changed the title Update AzureDNS docs azuredns: update docs Aug 11, 2023
@jlaundry
Copy link
Contributor Author

🤦🏻‍♂️ very sorry, updated now

Copy link
Contributor

@pchanvallon pchanvallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ldez ldez added this to the v4.14 milestone Aug 11, 2023
@ldez ldez force-pushed the jlaundry-patch-1 branch 2 times, most recently from 4c2b25d to a2f4cdf Compare August 11, 2023 13:50
@ldez ldez enabled auto-merge (squash) August 11, 2023 13:55
@ldez ldez merged commit f4f42f1 into go-acme:master Aug 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants