-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liquidweb: detect zone automatically #2031
Conversation
then i went looking at the thing to List zones, cause I think that's wrong then i wrote a test for that, and noticed that we can't test because of cyclic dependencies Then I noticed go-lwapi is still in use.
Signed-off-by: Jack Hayhurst <[email protected]>
Signed-off-by: Jack Hayhurst <[email protected]>
Signed-off-by: Jack Hayhurst <[email protected]>
Hello, Why did you change the prefix? |
All the PR should be rewritten to:
I will rewrite it. |
I changed the prefix so it matches our terraform provider and upcoming prefix for the CLI and other tooling. However, I changed it in a way so that the old prefix still works. I believe I have tests showing that as well. I did not see anything specifying a standard around the prefix. If that's an issue, we can leave it as |
I will merge the PR without the I will extend the system I created to handle fallback env vars for the cloudflare provider to be usable in this context. I will create a PR with the support of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Fernandez Ludovic <[email protected]>
I work for LiquidWeb, and we'd like to get some updates into our provider in lego to simplify things a bit and change the API endpoint.
I've followed the guidelines at https://github.com/go-acme/lego/blob/2140e6befe2a46267c88c735a40f4791fe6036ab/CONTRIBUTING.md and will open an issue as well once I've got this open.
I'm skipping including
make test
cause of the long output, but it passes as well.I'm guessing you'll squash my commits, which is fine if needed. Or I can submit another and squash them myself if needed.