Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredns: use TenantID also for cli authentication #2176

Merged
merged 1 commit into from
May 7, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 6, 2024

Users with several tenants should have a way to use a specific one for authentication.

Fixes #2178

@ldez ldez changed the title fix: Respect TenantID also for cli authentication on AzureDNS azuredns: use TenantID also for cli authentication May 6, 2024
@ldez ldez self-requested a review May 6, 2024 13:43
@ldez ldez added the bug label May 6, 2024
@ldez ldez added this to the v4.17 milestone May 6, 2024
@orgads orgads force-pushed the azuredns-cli-tenant branch 3 times, most recently from 5921e65 to 29fc4d8 Compare May 6, 2024 13:49
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Users with several tenants should have a way to use a specific one for
authentication.

Fixes go-acme#2178.
@ldez ldez enabled auto-merge (squash) May 7, 2024 18:40
@ldez ldez merged commit 2ec9e42 into go-acme:master May 7, 2024
4 checks passed
@orgads orgads deleted the azuredns-cli-tenant branch May 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

azuredns: CLI authentication doesn't respect tenant setting
2 participants