Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make go-chef HTTP headers compliant with RFC 2616 (HTTP/1.1) and go1.6 #75

Merged
merged 1 commit into from
Feb 19, 2016
Merged

make go-chef HTTP headers compliant with RFC 2616 (HTTP/1.1) and go1.6 #75

merged 1 commit into from
Feb 19, 2016

Commits on Feb 19, 2016

  1. make go-chef HTTP headers compliant with RFC 2616 (HTTP/1.1) and go1.6 

    [RFC 2616 § 4.2](https://www.ietf.org/rfc/rfc2616.txt) specifies that HTTP headers **cannot** contain spaces. A space being included in the header is in violation of the HTTP/1.1 standard. Unfortunately, Go 1.6 introduced a change where they outright reject requests, before the your HTTP handler is invoked, if **any** header contains a space in the name:

* golang/go@c052222

This changeset alters the `SignRequest` function so that the `Hashed Path` header is no longer sent to the Chef Server. The Chef authentication documentation clearly indicates that this header is **NOT** required to be sent over HTTP as part of authentication. The value is, however, used as part of the generation of the `X-Ops-Authorization` header.
    @theckman
    theckman committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    6c77fc6 View commit details
    Browse the repository at this point in the history