Remove go.mod, stick to +incompatible versions for v3.x #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to live without go.mod file, since chi was already v3.x before the Go modules support. See discussion at #302.
Assuming we release v3.3.3 tag:
Current master:
(adds github.com/go-chi/chi v0.0.0-20180826211853-0dd0f5c3134f into go.mod file)
With this PR merged:
(adds github.com/go-chi/chi v3.3.3+incompatible into go.mod file)
Summary
v3.3.3+incompatiblelooks much more cleaner than release chi as "v1" Go module. Imho, it'd be weird to release v1 module, since we're tagging with v3 version already.If we ever release v4, we can add go.mod file with
/v4import path suffix.