Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stubs to allow compilation under GOOS=tamago #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abarisani
Copy link

@abarisani abarisani commented Feb 1, 2024

The TamaGo bare metal framework would benefit from being able to integrate go-git on bare metal firmware.

This PR, in combination with this go-git PR adds the required stubs to allow compilation under GOOS=tamago.

Thanks

@pjbgf
Copy link
Member

pjbgf commented Feb 1, 2024

It would be great to have tests to ensure we won't get regressions in the future. Can you please add something around the lines of what we have for wasi or wasm?

@pjbgf pjbgf added the enhancement New feature or request label Feb 1, 2024
@abarisani
Copy link
Author

abarisani commented Feb 1, 2024

It would be great to have tests to ensure we won't get regressions in the future. Can you please add something around the lines of what we have for wasi or wasm?

This would require downloading and using our own compiler rather than stock Go, would you be fine with this? (for all intents and purposes we are identical to js at this point)

@pjbgf
Copy link
Member

pjbgf commented Feb 16, 2024

@abarisani yep, that's fine. Something around the likes of #44 should be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants