Skip to content

Commit

Permalink
Remove polluted ".ui.left" style (#26809)
Browse files Browse the repository at this point in the history
  • Loading branch information
wxiaoguang authored Aug 30, 2023
1 parent 2590707 commit 1bb9b1c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 36 deletions.
16 changes: 4 additions & 12 deletions templates/repo/settings/collaboration.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,8 @@
<div class="ui bottom attached segment">
<form class="ui form" id="repo-collab-form" action="{{.Link}}" method="post">
{{.CsrfTokenHtml}}
<div class="inline field ui left">
<div id="search-user-box" class="ui search">
<div class="ui input">
<input class="prompt" name="collaborator" placeholder="{{.locale.Tr "repo.settings.search_user_placeholder"}}" autocomplete="off" autofocus required>
</div>
</div>
<div id="search-user-box" class="ui search input gt-vm">
<input class="prompt" name="collaborator" placeholder="{{.locale.Tr "repo.settings.search_user_placeholder"}}" autocomplete="off" autofocus required>
</div>
<button class="ui green button">{{.locale.Tr "repo.settings.add_collaborator"}}</button>
</form>
Expand Down Expand Up @@ -93,12 +89,8 @@
{{if $allowedToChangeTeams}}
<form class="ui form" id="repo-collab-team-form" action="{{.Link}}/team" method="post">
{{.CsrfTokenHtml}}
<div class="inline field ui left">
<div id="search-team-box" class="ui search" data-org="{{.OrgName}}">
<div class="ui input">
<input class="prompt" name="team" placeholder="{{$.locale.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required>
</div>
</div>
<div id="search-team-box" class="ui search input gt-vm">
<input class="prompt" name="team" placeholder="{{$.locale.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required>
</div>
<button class="ui green button">{{$.locale.Tr "repo.settings.add_team"}}</button>
</form>
Expand Down
5 changes: 0 additions & 5 deletions web_src/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -1179,11 +1179,6 @@ img.ui.avatar,
font-size: 0.75em;
}

/* FIXME: this is a serious pollution, do not use this for "float: left" anymore */
.ui.left:not(.action) {
float: left;
}

/* FIXME: this is a serious pollution, do not use this for "float: right" anymore */
.ui.right:not(.action) {
float: right;
Expand Down
18 changes: 0 additions & 18 deletions web_src/css/repo.css
Original file line number Diff line number Diff line change
Expand Up @@ -1907,24 +1907,6 @@
flex-wrap: wrap;
}

.repository.settings.collaboration #repo-collab-form #search-user-box .results {
left: 7px;
}

.repository.settings.collaboration #repo-collab-form .ui.button {
margin-left: 5px;
margin-top: -3px;
}

.repository.settings.collaboration #repo-collab-team-form #search-team-box .results {
left: 7px;
}

.repository.settings.collaboration #repo-collab-team-form .ui.button {
margin-left: 5px;
margin-top: -3px;
}

/* if the element is for a checkbox, then it should have a padding-left to align to the checkbox's text */
.repository.settings.branches .branch-protection .ui.checkbox .help,
.repository.settings.branches .branch-protection .checkbox-sub-item {
Expand Down
2 changes: 1 addition & 1 deletion web_src/js/components/DashboardRepoList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</a>
</h4>
<div class="ui attached segment repos-search">
<div class="ui fluid right action left icon input" :class="{loading: isLoading}">
<div class="ui fluid action left icon input" :class="{loading: isLoading}">
<input type="search" spellcheck="false" maxlength="255" @input="changeReposFilter(reposFilter)" v-model="searchQuery" ref="search" @keydown="reposFilterKeyControl" :placeholder="textSearchRepos">
<i class="icon"><svg-icon name="octicon-search" :size="16"/></i>
<div class="ui dropdown icon button" :title="textFilter">
Expand Down

0 comments on commit 1bb9b1c

Please sign in to comment.