Skip to content

Commit

Permalink
Remove worker-loader (#23548)
Browse files Browse the repository at this point in the history
[`worker-loader`](https://github.com/webpack-contrib/worker-loader) is
deprecated since webpack 5 which can load workers without it now, so
remove it. I think it was already dysfunctional because the regex does
not match our current worker scripts:

```
web_src/js/features/eventsource.sharedworker.js
web_src/js/features/serviceworker.js
web_src/js/serviceworker.js
```

I did confirm that eventsource worker still loads via simple
`console.log` inside the script.

Co-authored-by: delvh <[email protected]>
  • Loading branch information
silverwind and delvh authored Mar 18, 2023
1 parent fe8b6cb commit 48f6805
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 121 deletions.
108 changes: 0 additions & 108 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"webpack-cli": "5.0.1",
"workbox-routing": "6.5.4",
"workbox-strategies": "6.5.4",
"worker-loader": "3.0.8",
"wrap-ansi": "8.1.0"
},
"devDependencies": {
Expand Down
12 changes: 0 additions & 12 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,6 @@ export default {
exclude: /node_modules/,
loader: 'vue-loader',
},
{
test: /\.worker\.js$/,
exclude: /monaco/,
use: [
{
loader: 'worker-loader',
options: {
inline: 'no-fallback',
},
},
],
},
{
test: /\.js$/,
exclude: /node_modules/,
Expand Down

0 comments on commit 48f6805

Please sign in to comment.