Skip to content

Commit

Permalink
Let return correct perm (#18675) (#18689)
Browse files Browse the repository at this point in the history
Backport of #18675
  • Loading branch information
Gusted authored Feb 9, 2022
1 parent 38fc6c7 commit 4cfd62c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion models/unit/unit.go
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,12 @@ func AllUnitKeyNames() []string {
// MinUnitAccessMode returns the minial permission of the permission map
func MinUnitAccessMode(unitsMap map[Type]perm.AccessMode) perm.AccessMode {
res := perm.AccessModeNone
for _, mode := range unitsMap {
for t, mode := range unitsMap {
// Don't allow `TypeExternal{Tracker,Wiki}` to influence this as they can only be set to READ perms.
if t == TypeExternalTracker || t == TypeExternalWiki {
continue
}

// get the minial permission great than AccessModeNone except all are AccessModeNone
if mode > perm.AccessModeNone && (res == perm.AccessModeNone || mode < res) {
res = mode
Expand Down

0 comments on commit 4cfd62c

Please sign in to comment.