IsBranchExist: return false if provided name is empty (#8485) (#8492)

* IsBranchExist: return false if provided name is empty * Ensure that the reference returned is actually of a valid type
go-gitea · Oct 13, 2019 · 6cb9ce1 · 6cb9ce1
1 parent d93d5d7
commit 6cb9ce1
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/modules/git/repo_branch.go b/modules/git/repo_branch.go
@@ -28,8 +28,14 @@ func IsBranchExist(repoPath, name string) bool {
 
 // IsBranchExist returns true if given branch exists in current repository.
 func (repo *Repository) IsBranchExist(name string) bool {
-	_, err := repo.gogitRepo.Reference(plumbing.ReferenceName(BranchPrefix+name), true)
-	return err == nil
+	if name == "" {
+		return false
+	}
+	reference, err := repo.gogitRepo.Reference(plumbing.ReferenceName(BranchPrefix+name), true)
+	if err != nil {
+		return false
+	}
+	return reference.Type() != plumbing.InvalidReference
 }
 
 // Branch represents a Git branch.