Always wait for the cmd to finish (#14006)

After cancelling the context we still need to wait for the command to finish otherwise zombie processes may occur Fix #13987 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
go-gitea · Dec 17, 2020 · 80a299d · 80a299d
1 parent 5e09de1
commit 80a299d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/modules/git/command.go b/modules/git/command.go
@@ -153,6 +153,7 @@ func (c *Command) RunInDirTimeoutEnvFullPipelineFunc(env []string, timeout time.
 		err := fn(ctx, cancel)
 		if err != nil {
 			cancel()
+			_ = cmd.Wait()
 			return err
 		}
 	}