Fix panic when an invalid oauth2 name is passed

go-gitea · Aug 17, 2022 · 9c4da36 · 9c4da36
1 parent a4e91c4
commit 9c4da36
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/models/auth/oauth2.go b/models/auth/oauth2.go
@@ -512,10 +512,14 @@ func GetActiveOAuth2ProviderSources() ([]*Source, error) {
 func GetActiveOAuth2SourceByName(name string) (*Source, error) {
 	authSource := new(Source)
 	has, err := db.GetEngine(db.DefaultContext).Where("name = ? and type = ? and is_active = ?", name, OAuth2, true).Get(authSource)
-	if !has || err != nil {
+	if err != nil {
 		return nil, err
 	}
 
+	if !has {
+		return nil, fmt.Errorf("oauth2 source not found, name: %q", name)
+	}
+
 	return authSource, nil
 }