Disable sending email after push a commit to a closed PR (#23462) (#2…

…3492) Backport #23462 by @sillyguodong Close #23440 Cause by #23189 In #23189, we should insert a comment record into db when pushing a commit to the PR, even if the PR is closed. But should skip sending any notification in this case. Co-authored-by: sillyguodong <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: KN4CK3R <[email protected]>
go-gitea · Mar 15, 2023 · d73846f · d73846f
1 parent 527bbf6
commit d73846f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/services/pull/pull.go b/services/pull/pull.go
@@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
 				continue
 			}
 
+			// If the PR is closed, someone still push some commits to the PR,
+			// 1. We will insert comments of commits, but hidden until the PR is reopened.
+			// 2. We won't send any notification.
 			AddToTaskQueue(pr)
 			comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
-			if err == nil && comment != nil {
+			if err == nil && comment != nil && !pr.Issue.IsClosed {
 				notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
 			}
 		}