Times API breaks after deleting repo containing issues with tracked times

[bobemoe]

• Gitea version (or commit ref): 1.12.0+dev-307-g62a1322cf
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

After deleting a repo the times API has become unusable:

$ curl -X GET "https://bobemoe:[email protected]/api/v1/user/times" -H  "accept: application/json"
{"message":"issue does not exist [id: 9010, repo_id: 0, index: 0]","url":"https://try.gitea.io/api/swagger"}

I've checked the DB and indeed the issue records for the deleted repo have been deleted but there are still records in the tracked_time table that now have a non-existent issue_id:

mysql> select t.*,i.id from tracked_time t left join issue i on t.issue_id=i.id having i.id is null;
+----+----------+---------+--------------+-------+---------+------+
| id | issue_id | user_id | created_unix | time  | deleted | id   |
+----+----------+---------+--------------+-------+---------+------+
|  3 |     1361 |       1 |   1571125831 |  3600 |       0 | NULL |
|  4 |     1361 |       1 |   1571125838 |  1500 |       0 | NULL |
....

[6543]

so on repoDeletion we have to delete tracked_time too

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[bobemoe]

Still an issue, confirmed on try.gitea.io

[6543]

I'll have a look at it

[6543]

ok Idear:

• fix models.DeleteRepository()
• add a task to gitea doctor witch check general DB consistency
  (witch can fix DBs witch have already TrackedTimes of deleted repos)

[6543]

@bobemoe -> #11110 & #11111