Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git hooks are not being executed on Windows when running as a service #1139

Closed
andreynering opened this issue Mar 7, 2017 · 3 comments · Fixed by #1149
Closed

Git hooks are not being executed on Windows when running as a service #1139

andreynering opened this issue Mar 7, 2017 · 3 comments · Fixed by #1149
Labels
type/bug
Milestone
1.1.0

Comments

@andreynering
Copy link
Contributor

Similar to #736

When hooks call Gitea executable, it immediately stop because it conflicts with minwinsvc. If it's not running as service, it works normally.

Set env SKIP_MINWINSVC=1 should work.
@andreynering andreynering added this to the 1.1.0 milestone Mar 7, 2017
@lunny
Copy link
Member

lunny commented Mar 8, 2017

Should this be put to v1.1? Maybe we can move this to 1.2? @andreynering

@andreynering
Copy link
Contributor Author

This was working before, I think we should really fix for v1.1

I'll try to fix later today, I think it's trivial.

Where are Git hooks located on source code and how can we update it on a migration?

@lunny
Copy link
Member

lunny commented Mar 8, 2017

See this PR #1006. We will wait for this issue to release 1.1 .

@andreynering andreynering mentioned this issue Mar 8, 2017
Merged
lunny pushed a commit that referenced this issue Mar 9, 2017
@andreynering @lunny
Fix Git hooks not being executed on Windows when running as a service (…
d2b2881 
…#1149)

Closes #1139
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Fix Git hooks not being executed on Windows when running as a service
2 participants
@lunny @andreynering