Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personal Secrets store and Organization secrets store #12065

Closed
lunny opened this issue Jun 27, 2020 · 0 comments · Fixed by #22142
Closed

Personal Secrets store and Organization secrets store #12065

lunny opened this issue Jun 27, 2020 · 0 comments · Fixed by #22142
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.19.0

Comments

@lunny
Copy link
Member

lunny commented Jun 27, 2020

When you want to migrate from a SSH or from a private Github repository, You have to input the token or private key to do that. A more convenient way is to store all the secrets on gitea and use them when needed.

For a self-hosted instance, we should store them as encrypted data. A random key could be saved on user table to encrypt/decrypt the data.
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jun 27, 2020
@lunny lunny mentioned this issue Jun 27, 2020
Open
5 tasks
@TheoLassonder TheoLassonder mentioned this issue Aug 5, 2020
Closed
@lunny lunny mentioned this issue Aug 5, 2020
Closed
@kdumontnu kdumontnu mentioned this issue Mar 22, 2021
Closed
@wolfogre wolfogre mentioned this issue Dec 15, 2022
Merged
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 15, 2022
@lunny lunny added this to the 1.19.0 milestone Dec 15, 2022
lunny added a commit that referenced this issue Dec 20, 2022
@wolfogre @lafriks
@lunny @wxiaoguang @delvh @KN4CK3R
Secrets storage with SecretKey encrypted (#22142)
6590551 
Fork of #14483, but [gave up
MasterKey](#14483 (comment)),
and fixed some problems.

Close #12065.
Needed by #13539.

Featrues:
- Secrets for repo and org, not user yet.
- Use SecretKey to encrypte/encrypt secrets.
- Trim spaces of secret value.
- Add a new locale ini block, to make it easy to support secrets for
user.

Snapshots:

Repo level secrets:

![image](https://user-images.githubusercontent.com/9418365/207823319-b8a4903f-38ca-4af7-9d05-336a5af906f3.png)

Rrg level secrets

![image](https://user-images.githubusercontent.com/9418365/207823371-8bd02e93-1928-40d1-8c76-f48b255ace36.png)

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: delvh <[email protected]>
Co-authored-by: KN4CK3R <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Secrets storage with SecretKey encrypted
1 participant
@lunny