Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] add api access to git notes #15373

Closed
eveslage opened this issue Apr 9, 2021 · 20 comments · Fixed by #16649
Closed

[Proposal] add api access to git notes #15373

eveslage opened this issue Apr 9, 2021 · 20 comments · Fixed by #16649
Labels
good first issue Likely to be an easy fix modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@eveslage
Copy link

eveslage commented Apr 9, 2021

Your api is quite powerful to access al kinds of information in a git repository. But there is no way to access git-notes.

https://git-scm.com/docs/git-notes

we use git-notes to annotate commits without changing the commit itself. git log shows them along with the commit messages and gitea shows them in the web ui. But the api access is missing.

it would be nice to have access to git-notes though the api.
@a1012112796 a1012112796 added good first issue Likely to be an easy fix type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 9, 2021
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label Apr 9, 2021
@emilekm
Copy link

emilekm commented Apr 24, 2021 •
edited
Loading 

// swagger:operation POST /repos/{owner}/{repo}/git/notes/{sha} repository repoCreateNote
// swagger:operation GET /repos/{owner}/{repo}/git/notes/{sha} repository repoGetNote
// swagger:operation PATCH /repos/{owner}/{repo}/git/notes/{sha} repository repoUpdateNote
// swagger:operation DELETE /repos/{owner}/{repo}/git/notes/{sha} repository repoDeleteNote

sha is the commit SHA, body for POST and PATCH would contain only the message.

This is minimal version, I don't see a need to include anything else (like merging notes).
If this looks ok to you I can send MR soon (already did some work).

@emilekm
Copy link

emilekm commented Apr 24, 2021

Also, do you need a list endpoint?

@eveslage
Copy link
Author

That’s good news. I believe for our use case the best would be to have the git-notes info available when retrieving the commits from a repo, for instance, through: /repos/{owner}/{repo}/commits

If there is a performance concern over the general use case, we would also be fine with an additional query parameter that could specify whether to retrieve this data or not.

@nitul1991
Copy link
Contributor

Is this issue still open? I'd like to contribute to gitea and this seems like a good first issue.

@zeripath
Copy link
Contributor

yup it's still open.

@nitul1991
Copy link
Contributor

Thanks for confirming @zeripath. Any tips on getting started with this issue?

@6543
Copy link
Member

6543 commented Jul 20, 2021 •
edited
Loading

@nitul1991

1.I would say add func to module/git to be able to interact with notes
2. Add smal unit test for them
3. Add add endpoint
4. Add smal integration test for api

If you need help etc ... feel free to chat with us on discord

@nitul1991
Copy link
Contributor

Thanks @zeripath! This should be enough to get me started.

This was referenced Aug 9, 2021
Closed
Merged
Merged
nitul1991 added a commit to nitul1991/gitea that referenced this issue Aug 10, 2021
@nitul1991
Add an api endpoint to fetch git notes (go-gitea#15373)
205043c
@6543 6543 mentioned this issue Aug 11, 2021
Merged
6543 pushed a commit that referenced this issue Aug 11, 2021
@nitul1991
Add an api endpoint to fetch git notes (#15373) (#16649)
2d25b7d 
close #15373
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

pardon me for asking if this is obvious, but where in the web ui are git notes shown?

as per OP:

we use git-notes to annotate commits without changing the commit itself. git log shows them along with the commit messages and gitea shows them in the web ui.

for referrence, I am running Gitea Version: 1.16.0+dev-96-gf1a810e09

@eveslage
Copy link
Author

if there are any notes, you can see them right below the git commit message
129324253-466a9cd9-1c8a-41d5-9c54-df5f4324846f

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

thanks for the response @eveslage
yeah, I don't see any notes there (added with git notes add before pushing to remote), tried with multiple commits.
is your repo public or private? although that didn't matter in my case, neither showed the notes...
the notes should be pushed to remote alongside regular objects automatically, have you done anything special to show them Gitea-side or did it just work for you?

@nitul1991
Copy link
Contributor

git notes are not pushed to a remote along with normal commits.

Please check out this link for more information.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented Aug 13, 2021 via email •
edited by 6543
Loading

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

alright, so I still haven't managed to successfully conclude the thing.
I am getting this when I try to push notes with git push -u origin refs/notes/"*":refs/notes/"*"

log (click me pls) 
Aug 13 17:30:46 nebula gitea[3105419]: 2021/08/13 17:30:46 Started GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack for 127.0.0.1:0
Aug 13 17:30:46 nebula gitea[3105419]: 2021/08/13 17:30:46 Completed GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack 200 OK in 11.35454ms
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 ...ters/private/hook.go:470:HookPreReceive() [E] Unexpected ref: refs/notes/commits
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/hook.go:470 (0x21ad554)
Aug 13 17:30:47 nebula gitea[3105419]:                 HookPreReceive: log.Error("Unexpected ref: %s", refFullName)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:76 (0x203cfbb)
Aug 13 17:30:47 nebula gitea[3105419]:                 Wrap.func1: t(ctx)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/internal.go:31 (0x21c03a4)
Aug 13 17:30:47 nebula gitea[3105419]:                 CheckInternalToken.func1: next.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/context/private.go:42 (0x171494f)
Aug 13 17:30:47 nebula gitea[3105419]:                 PrivateContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:70 (0x16f04ca)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:311 (0x16f68bb)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).Mount.func1: handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:72 (0x20651bd)
Aug 13 17:30:47 nebula gitea[3105419]:                 Middlewares.func2.1: next.ServeHTTP(resp, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/logger.go:23 (0x20643fb)
Aug 13 17:30:47 nebula gitea[3105419]:                 LoggerHandler.func1.1: next.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2060fe7)
Aug 13 17:30:47 nebula gitea[3105419]:                 StripSlashes.func1: next.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x205c64e)
Aug 13 17:30:47 nebula gitea[3105419]:                 ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:25 (0x2064cfc)
Aug 13 17:30:47 nebula gitea[3105419]:                 Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:87 (0x16f0250)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:318 (0x203c333)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/gorilla/context/context.go:141 (0x130d5d3)
Aug 13 17:30:47 nebula gitea[3105419]:                 ClearHandler.func1: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2867 (0x7bbca2)
Aug 13 17:30:47 nebula gitea[3105419]:                 serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:1932 (0x7b71cc)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/runtime/asm_amd64.s:1371 (0x4747c0)
Aug 13 17:30:47 nebula gitea[3105419]:                 goexit: BYTE        $0x90        // NOP
Aug 13 17:30:47 nebula gitea[3105419]:
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test 500 Internal Server Error in 50.831694ms
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/ssh/log for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/ssh/log 200 OK in 226.779µs
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/ssh/3/update/647 for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/ssh/3/update/647 200 OK in 5.372184ms
...
Aug 13 17:35:00 nebula gitea[3105419]: 2021/08/13 17:35:00 Started GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack for 127.0.0.1:0
Aug 13 17:35:00 nebula gitea[3105419]: 2021/08/13 17:35:00 Completed GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack 200 OK in 8.900563ms
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 ...ters/private/hook.go:470:HookPreReceive() [E] Unexpected ref: refs/notes/commits
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/hook.go:470 (0x21ad554)
Aug 13 17:35:01 nebula gitea[3105419]:                 HookPreReceive: log.Error("Unexpected ref: %s", refFullName)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:76 (0x203cfbb)
Aug 13 17:35:01 nebula gitea[3105419]:                 Wrap.func1: t(ctx)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/internal.go:31 (0x21c03a4)
Aug 13 17:35:01 nebula gitea[3105419]:                 CheckInternalToken.func1: next.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/context/private.go:42 (0x171494f)
Aug 13 17:35:01 nebula gitea[3105419]:                 PrivateContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:70 (0x16f04ca)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:311 (0x16f68bb)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).Mount.func1: handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:72 (0x20651bd)
Aug 13 17:35:01 nebula gitea[3105419]:                 Middlewares.func2.1: next.ServeHTTP(resp, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/logger.go:23 (0x20643fb)
Aug 13 17:35:01 nebula gitea[3105419]:                 LoggerHandler.func1.1: next.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2060fe7)
Aug 13 17:35:01 nebula gitea[3105419]:                 StripSlashes.func1: next.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x205c64e)
Aug 13 17:35:01 nebula gitea[3105419]:                 ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:25 (0x2064cfc)
Aug 13 17:35:01 nebula gitea[3105419]:                 Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:87 (0x16f0250)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:318 (0x203c333)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/gorilla/context/context.go:141 (0x130d5d3)
Aug 13 17:35:01 nebula gitea[3105419]:                 ClearHandler.func1: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2867 (0x7bbca2)
Aug 13 17:35:01 nebula gitea[3105419]:                 serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:1932 (0x7b71cc)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/runtime/asm_amd64.s:1371 (0x4747c0)
Aug 13 17:35:01 nebula gitea[3105419]:                 goexit: BYTE        $0x90        // NOP
Aug 13 17:35:01 nebula gitea[3105419]:
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test 500 Internal Server Error in 121.080434ms
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/ssh/log for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/ssh/log 200 OK in 161.392µs
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/ssh/3/update/647 for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/ssh/3/update/647 200 OK in 26.496472ms

client-side, this is what I get

➜  git push -u origin refs/notes/"*":refs/notes/"*" --verbose
Pushing to thedomain:wanderer/gitea-git-notes-test.git
Enumerating objects: 3, done.
Counting objects: 100% (3/3), done.
Delta compression using up to 4 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 273 bytes | 273.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
remote:
remote: Gitea: Internal Server Error
remote: Gitea: Internal Server Error
To thedomain:wanderer/gitea-git-notes-test.git
 ! [remote rejected] refs/notes/commits -> refs/notes/commits (pre-receive hook declined)
error: failed to push some refs to 'thedomain:wanderer/gitea-git-notes-test.git'

am I doing something wrong or is this for another issue?

@zeripath
Copy link
Contributor 

remote: Gitea: Internal Server Error
remote: Gitea: Internal Server Error

This is not normal. Check your logs.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor 

remote: Gitea: Internal Server Error
remote: Gitea: Internal Server Error

This is not normal. Check your logs.

I have, they are linked in my previous post.

@zeripath
Copy link
Contributor

I have, they are linked in my previous post.

Which post?

By logs I mean the logs on Gitea.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

this thing here a couple of messages back under "logs" - contains this:

Aug 13 17:30:46 nebula gitea[3105419]: 2021/08/13 17:30:46 Started GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack for 127.0.0.1:0
Aug 13 17:30:46 nebula gitea[3105419]: 2021/08/13 17:30:46 Completed GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack 200 OK in 11.35454ms
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 ...ters/private/hook.go:470:HookPreReceive() [E] Unexpected ref: refs/notes/commits
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/hook.go:470 (0x21ad554)
Aug 13 17:30:47 nebula gitea[3105419]:                 HookPreReceive: log.Error("Unexpected ref: %s", refFullName)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:76 (0x203cfbb)
Aug 13 17:30:47 nebula gitea[3105419]:                 Wrap.func1: t(ctx)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/internal.go:31 (0x21c03a4)
Aug 13 17:30:47 nebula gitea[3105419]:                 CheckInternalToken.func1: next.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/context/private.go:42 (0x171494f)
Aug 13 17:30:47 nebula gitea[3105419]:                 PrivateContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:70 (0x16f04ca)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:311 (0x16f68bb)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).Mount.func1: handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:72 (0x20651bd)
Aug 13 17:30:47 nebula gitea[3105419]:                 Middlewares.func2.1: next.ServeHTTP(resp, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/logger.go:23 (0x20643fb)
Aug 13 17:30:47 nebula gitea[3105419]:                 LoggerHandler.func1.1: next.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2060fe7)
Aug 13 17:30:47 nebula gitea[3105419]:                 StripSlashes.func1: next.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x205c64e)
Aug 13 17:30:47 nebula gitea[3105419]:                 ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:25 (0x2064cfc)
Aug 13 17:30:47 nebula gitea[3105419]:                 Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:87 (0x16f0250)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:318 (0x203c333)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/gorilla/context/context.go:141 (0x130d5d3)
Aug 13 17:30:47 nebula gitea[3105419]:                 ClearHandler.func1: h.ServeHTTP(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:30:47 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2867 (0x7bbca2)
Aug 13 17:30:47 nebula gitea[3105419]:                 serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:1932 (0x7b71cc)
Aug 13 17:30:47 nebula gitea[3105419]:                 (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
Aug 13 17:30:47 nebula gitea[3105419]:         /usr/lib/go/src/runtime/asm_amd64.s:1371 (0x4747c0)
Aug 13 17:30:47 nebula gitea[3105419]:                 goexit: BYTE        $0x90        // NOP
Aug 13 17:30:47 nebula gitea[3105419]:
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test 500 Internal Server Error in 50.831694ms
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/ssh/log for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/ssh/log 200 OK in 226.779µs
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Started POST /api/internal/ssh/3/update/647 for 127.0.0.1:0
Aug 13 17:30:47 nebula gitea[3105419]: 2021/08/13 17:30:47 Completed POST /api/internal/ssh/3/update/647 200 OK in 5.372184ms
...
Aug 13 17:35:00 nebula gitea[3105419]: 2021/08/13 17:35:00 Started GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack for 127.0.0.1:0
Aug 13 17:35:00 nebula gitea[3105419]: 2021/08/13 17:35:00 Completed GET /api/internal/serv/command/3/wanderer/gitea-git-notes-test?mode=2&verb=git-receive-pack 200 OK in 8.900563ms
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 ...ters/private/hook.go:470:HookPreReceive() [E] Unexpected ref: refs/notes/commits
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/hook.go:470 (0x21ad554)
Aug 13 17:35:01 nebula gitea[3105419]:                 HookPreReceive: log.Error("Unexpected ref: %s", refFullName)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:76 (0x203cfbb)
Aug 13 17:35:01 nebula gitea[3105419]:                 Wrap.func1: t(ctx)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/private/internal.go:31 (0x21c03a4)
Aug 13 17:35:01 nebula gitea[3105419]:                 CheckInternalToken.func1: next.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/context/private.go:42 (0x171494f)
Aug 13 17:35:01 nebula gitea[3105419]:                 PrivateContexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:70 (0x16f04ca)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:311 (0x16f68bb)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).Mount.func1: handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:436 (0x16f296a)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).routeHTTP: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:72 (0x20651bd)
Aug 13 17:35:01 nebula gitea[3105419]:                 Middlewares.func2.1: next.ServeHTTP(resp, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/logger.go:23 (0x20643fb)
Aug 13 17:35:01 nebula gitea[3105419]:                 LoggerHandler.func1.1: next.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2060fe7)
Aug 13 17:35:01 nebula gitea[3105419]:                 StripSlashes.func1: next.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x205c64e)
Aug 13 17:35:01 nebula gitea[3105419]:                 ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/routers/common/middleware.go:25 (0x2064cfc)
Aug 13 17:35:01 nebula gitea[3105419]:                 Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/go-chi/chi/mux.go:87 (0x16f0250)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/modules/web/route.go:318 (0x203c333)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /opt/gitea/gitea-src/vendor/github.com/gorilla/context/context.go:141 (0x130d5d3)
Aug 13 17:35:01 nebula gitea[3105419]:                 ClearHandler.func1: h.ServeHTTP(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2049 (0x7b86e3)
Aug 13 17:35:01 nebula gitea[3105419]:                 HandlerFunc.ServeHTTP: f(w, r)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:2867 (0x7bbca2)
Aug 13 17:35:01 nebula gitea[3105419]:                 serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/net/http/server.go:1932 (0x7b71cc)
Aug 13 17:35:01 nebula gitea[3105419]:                 (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
Aug 13 17:35:01 nebula gitea[3105419]:         /usr/lib/go/src/runtime/asm_amd64.s:1371 (0x4747c0)
Aug 13 17:35:01 nebula gitea[3105419]:                 goexit: BYTE        $0x90        // NOP
Aug 13 17:35:01 nebula gitea[3105419]:
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/hook/pre-receive/wanderer/gitea-git-notes-test 500 Internal Server Error in 121.080434ms
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/ssh/log for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/ssh/log 200 OK in 161.392µs
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Started POST /api/internal/ssh/3/update/647 for 127.0.0.1:0
Aug 13 17:35:01 nebula gitea[3105419]: 2021/08/13 17:35:01 Completed POST /api/internal/ssh/3/update/647 200 OK in 26.496472ms

@techknowlogick
Copy link
Member

Please don't debug in a closed issue. If Gitea is broken please open a new issue, otherwise please join chat.

@go-gitea go-gitea locked and limited conversation to collaborators Aug 13, 2021
@zeripath
Copy link
Contributor

Looks like this is a real bug and regression from #15629

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf can you open a new issue please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Likely to be an easy fix modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add API to fetch git notes nitul1991/gitea
8 participants
@techknowlogick @emilekm @zeripath @nitul1991 @eveslage @6543 @a1012112796 @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf