Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Do not reload page after resolving a conversation #15981

Closed
delvh opened this issue May 25, 2021 · 2 comments · Fixed by #28654
Closed

[Bug] Do not reload page after resolving a conversation #15981

delvh opened this issue May 25, 2021 · 2 comments · Fixed by #28654
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@delvh
Copy link
Member

delvh commented May 25, 2021

  • Gitea version (or commit ref): 1.15.0+dev-344-g5285a3e70
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes: Feel free to experiment here yourself

Description

Currently, when resolving a conversation in a PR inside the Conversation tab, the page automatically gets reloaded.
Surprisingly, when resolving a conversation there inside the Files Changed tab, then it does not get reloaded.
This is interesting as I would have expected both to use the same exact code, given that both should do exactly the same.
Would it be possible to not have to endure a reload every time a conversation is resolved in the Conversation tab, simply by replacing the currently present code with the one used in the Files changed tab?
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 26, 2021
@thigg
Copy link
Contributor

thigg commented Oct 25, 2023

very annoying if you got a long code review, because the page jumps to the top everytime you resolve a conversation

@jpraet jpraet mentioned this issue Dec 29, 2023
Merged
jpraet added a commit to jpraet/gitea that referenced this issue Jan 6, 2024
@jpraet
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
bc4c13b 
…page-reload
jpraet added a commit to jpraet/gitea that referenced this issue Jan 12, 2024
@jpraet
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
e18e7e9 
…page-reload
jpraet added a commit to jpraet/gitea that referenced this issue Jan 19, 2024
@jpraet
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
30b974c 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 22, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
bddc4e0 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 23, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
4d58cfd 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 23, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
562ade7 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
9d4cb81 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
34a21b0 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
b353825 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
a40c3fb 
…page-reload
GiteaBot added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@GiteaBot
Merge branch 'main' into go-gitea#15981-resolve-conversation-without-…
8516ae7 
…page-reload
lunny pushed a commit that referenced this issue Jan 24, 2024
@jpraet
Don't reload timeline page when (un)resolving or replying conversation (
ee3e83e 
#28654)

Fixes #15981
jpraet added a commit to jpraet/gitea that referenced this issue Jan 24, 2024
@jpraet
Don't reload timeline page when (un)resolving or replying conversation (
0f018cb 
go-gitea#28654)

Backport go-gitea#28654

Fixes go-gitea#15981
@jpraet jpraet mentioned this issue Jan 24, 2024
Merged
KN4CK3R pushed a commit that referenced this issue Jan 24, 2024
@jpraet
Don't reload timeline page when (un)resolving or replying conversation (
9210ce4 
#28654) (#28917)

Backport #28654
Fixes #15981
henrygoodman pushed a commit to henrygoodman/gitea that referenced this issue Jan 31, 2024
@jpraet @henrygoodman
Don't reload timeline page when (un)resolving or replying conversation (
63aa1ba 
go-gitea#28654)

Fixes go-gitea#15981
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@jpraet @silverwind
Don't reload timeline page when (un)resolving or replying conversation (
e2177e9 
go-gitea#28654)

Fixes go-gitea#15981
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't reload timeline page when (un)resolving or replying conversation jpraet/gitea
3 participants
@zeripath @thigg @delvh