always running processes from 1.14.5=>1.15.2 #17007
Milestone
Comments
|
Is there actually a process associated with this on your system? |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Sep 10, 2021
When the external context is cancelled it is possible for the GitLogReader to not itself be Closed. This PR does three things: 1. Instead of adding a plain defer it wraps the `g.Close` in a func as `g` may change. 2. It adds the missing explicit g.Close - although the defer fix makes this unnecessary. 3. It passes down the external context as the base context for the GitLogReader meaning that the cancellation of the external context will pass down automatically. Fix go-gitea#17007 Signed-off-by: Andrew Thornton <[email protected]>
|
Apologies there appears to be a missing Close if the external context is cancelled and the defer wasn't firing due to a slight gotcha. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Sep 10, 2021
Backport go-gitea#17008 When the external context is cancelled it is possible for the GitLogReader to not itself be Closed. This PR does three things: 1. Instead of adding a plain defer it wraps the `g.Close` in a func as `g` may change. 2. It adds the missing explicit g.Close - although the defer fix makes this unnecessary. 3. It passes down the external context as the base context for the GitLogReader meaning that the cancellation of the external context will pass down automatically. Fix go-gitea#17007 Signed-off-by: Andrew Thornton <[email protected]>
lunny
pushed a commit
that referenced
this issue
Sep 10, 2021
Backport #17008 When the external context is cancelled it is possible for the GitLogReader to not itself be Closed. This PR does three things: 1. Instead of adding a plain defer it wraps the `g.Close` in a func as `g` may change. 2. It adds the missing explicit g.Close - although the defer fix makes this unnecessary. 3. It passes down the external context as the base context for the GitLogReader meaning that the cancellation of the external context will pass down automatically. Fix #17007 Signed-off-by: Andrew Thornton <[email protected]>
lunny
pushed a commit
that referenced
this issue
Sep 10, 2021
When the external context is cancelled it is possible for the GitLogReader to not itself be Closed. This PR does three things: 1. Instead of adding a plain defer it wraps the `g.Close` in a func as `g` may change. 2. It adds the missing explicit g.Close - although the defer fix makes this unnecessary. 3. It passes down the external context as the base context for the GitLogReader meaning that the cancellation of the external context will pass down automatically. Fix #17007 Signed-off-by: Andrew Thornton <[email protected]>
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
windowns
[x]):Description
always running processes from 1.14.5=>1.15.0=>1.15.1=>1.15.2
the bug from 1.15.x
not appear in 1.14.5
Screenshots
The text was updated successfully, but these errors were encountered: