Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repositories owner should not add himself as collaborator #17966

Closed
lunny opened this issue Dec 13, 2021 · 1 comment · Fixed by #20043
Closed

Repositories owner should not add himself as collaborator #17966

lunny opened this issue Dec 13, 2021 · 1 comment · Fixed by #20043
Labels
type/bug

Comments

@lunny
Copy link
Member

lunny commented Dec 13, 2021

No description provided.

@lunny lunny added the type/bug label Dec 13, 2021
@Gusted
Copy link
Contributor

Gusted commented Dec 16, 2021

Weird, this already should be covered:

gitea/routers/web/repo/setting.go

Line 806 in 3a3cbcf

if len(name) == 0 || ctx.Repo.Owner.LowerName == name {

42wim added a commit to 42wim/gitea that referenced this issue Jun 19, 2022
@42wim
Do not allow organisation owners add themselves as collaborator
f14f299 
We're already checking for repo owners, but we also need to check for
organisation owners.

Closes go-gitea#17966
@42wim 42wim mentioned this issue Jun 19, 2022
Merged
6543 pushed a commit that referenced this issue Sep 27, 2022
@42wim
Do not allow organisation owners add themselves as collaborator (#20043)
889a41c 
We're already checking for repo owners, but we also need to check for
organisation owners that try to add themselves as collaborator

Closes #17966
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow organisation owners add themselves as collaborator 42wim/gitea
2 participants
@lunny @Gusted