Tree view in Pull Requests, similar to GitLab/GitHub/Azure DevOps

[nunoperalta]

Feature Description

The current way Gitea shows the file changes on a Pull Request (whether in Preview/Simulation or when the PR is created), to me feels disorganized and hard to review, as it shows ALL files in the same page.
For big PRs, this gets really messy/hard.

I actually feel very comfortable reviewing PRs using Azure DevOps, as they show a tree of the files changed (organized by affected folders), so that we can review one by one, by clicking on the file we want to review, and it will show the whole file on the right side, with the changes.

https://docs.microsoft.com/en-us/azure/devops/repos/git/review-pull-requests?view=azure-devops&tabs=browser

Screenshots

--

[lunny]

We have one, but in the top.

[6543]

wasn't there a plugin out in the wild for github that also support gitea??

[wxiaoguang]

We have one, but in the top.

Does Gite has a tree view? I think the author means the left tree for file list, it's more friendly and easier to use.

[lunny]

We have one, but in the top.

Does Gite has a tree view? I think the author means the left tree for file list, it's more friendly and easier to use.

We have a file list on the top of the files view.

[nunoperalta]

We have one, but in the top.

Hey
Thanks for the reply.

I'm not sure I understand what you mean (or what your screenshot is showing).

There just seems to be plain text with the stats, and each box below has the name of the file.
But I don't find anywhere an organized Tree of files, which I can click to see that file individually.

Similar to using VS Code, opening a file from the File Explorer at the left side, and the contents appear on the right side.
But the Tree / File Explorer only contains the changed files,
and the left side would either contain a Split View or Unified View of differences.

[qm012]

expectation plus this need

[nunoperalta]

btw, GitHub is implementing that. It's available under "Feature preview", although I'm not seeing the new version yet (even if enabled).

But here's the image in the "Feature preview" area:

[nunoperalta]

Ah -- it's appearing to me now!!

Here's an example for this PR: https://github.com/go-gitea/gitea/pull/19007/files

[lunny]

As a workaround, you can use some chrome extensions, i.e. git-master

[delvh]

I have a suggestion for the icons:
While I do find it useful to display icons showing whether the file was added, modified, or deleted; I do not like the wasted space by displaying the file icon.
The folder icon is alright, as you can then quickly skim through which tree items are folders.
However, while using this feature in GitHub already, I noticed that there is unused potential here:
Instead of knowing that it is a file, I would find it much more useful to display a read-only checkbox (so most likely two different checkbox icons, one checked and one unchecked) showing whether you have already viewed this file while reviewing.
Implementing this is of course only possible once you can actually mark files as viewed, so it would depend on #19007 to get merged.

But the base implementation does not depend on this suggestion.

[sebastiande]

As a workaround, you can use some chrome extensions, i.e. git-master

I think git-master is always showing all files and not only the changed files of a pull request, so it does not help.

[denwwer]

Hi, is any updates about that?

[happyxhw]

+1

[sebastian-sauer]

I've tried to get a first file list on the left of the tree view.

fomantic will add support for a tree (hopefully) with the next 2.9 release - so for now this is (at least for me) a good step to have a file list on the left to easy navigate in a pr.

I've created a WIP PR #21012 with my changes.

[sebastian-sauer]

Please see the PR for an updated screenshot with a first non collapsible tree view of files.

[sebastian-sauer]

Now the tree has collapsible directories and a github like show / hide mechanism.

Please see updated screenshots in PR.