Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content of WebAuthN page is not center-aligned #21126

Closed
neonn opened this issue Sep 9, 2022 · 0 comments
Closed

Content of WebAuthN page is not center-aligned #21126

neonn opened this issue Sep 9, 2022 · 0 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@neonn
Copy link
Contributor

neonn commented Sep 9, 2022

Description

The content of the WebAuthN (used for USB authentication keys to login with a Gitea account) is left-aligned.

It affects both Chromium and Firefox (other browser engines have not been tested).

This can be corrected with adding center aligned to the column instance on the page. A separate pull request will be made and reference this issue shortly.

Screenshots

Without CSS class change:

Current site

With CSS class change:

CSS class change

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Arch Linux

Browser Version

Firefox Developer Edition (105.0b8 (64-bit))
@neonn neonn added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 9, 2022
@neonn neonn mentioned this issue Sep 9, 2022
Merged
techknowlogick pushed a commit that referenced this issue Sep 9, 2022
@neonn @wxiaoguang
Center-aligning content of WebAuthN page (#21127)
0bd5938 
<!--

Please check the following:

1. Make sure you are targeting the `main` branch, pull requests on
release branches are only allowed for bug fixes.
2. Read contributing guidelines:
https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md
3. Describe what your pull request does and which issue you're targeting
(if any)

-->

This attempts to correct #21126 , where the content of the page is not
center-aligned.

(Note: I think this contains the right commits - but, those other
commits seem superfluous. I'm not sure I've made the pull request
correctly. I don't often use the pull request pattern when working,
opting to use the merge-request pattern instead for my workplace. If
there are any issues, please let me know and I will try to correct
them.)

Co-authored-by: wxiaoguang <[email protected]>
@neonn neonn closed this as completed Sep 9, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neonn