Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI pushing commits with wrong author info #21485

Closed
yardenshoham opened this issue Oct 17, 2022 · 9 comments
Closed

CI pushing commits with wrong author info #21485

yardenshoham opened this issue Oct 17, 2022 · 9 comments
Assignees
@appleboy
Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@yardenshoham
Copy link
Member

yardenshoham commented Oct 17, 2022 •
edited
Loading

Description

Drone is pushing commits with the author info of the last committer, not the gitea bot

Gitea Version

cda2c38
@lunny lunny added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Oct 18, 2022
@lunny
Copy link
Member

lunny commented Oct 18, 2022

@appleboy

1 similar comment
@yardenshoham
Copy link
Member Author

@appleboy

@appleboy
Copy link
Member

I will take it.

@yardenshoham
Copy link
Member Author

@appleboy
Almost there
image
c5573db

@yardenshoham yardenshoham mentioned this issue Mar 19, 2023
Closed
@silverwind
Copy link
Member

silverwind commented Mar 19, 2023 •
edited
Loading

I'd recomment replacing drone-git-push with a few lines of git shell comands. Creating commits is not black magic and certainly does not need any further abstractions. See example of mine.

@appleboy
Copy link
Member

I create git-push-action to test CI/CD flow based on the drone-git-push plugin and the result is that the GitHub action is working but the drone plugin is not working. See the sample repository.

image

@techknowlogick
Copy link
Member

I've switched the drone cron pipelines to use (GitHub) Actions: #24314

@appleboy
Copy link
Member

@techknowlogick Good. We move to #24314

@appleboy
Copy link
Member

Fixed in #24314

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@appleboy appleboy

Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@appleboy @lunny @silverwind @techknowlogick @yardenshoham