Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to use Actions from drone for cron #24314

Merged
merged 8 commits into from
Apr 26, 2023

Conversation

techknowlogick
Copy link
Member

Move drone cron pipelines to (GitHub) Actions. As these are mostly compatible with Gitea Actions, when we start to dogfood, these will already be migrated.

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 25, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2023
.github/workflows/cron-translations.yml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2023
@wxiaoguang
Copy link
Contributor

That's a strange time.: "19 58 * * *" # every day at 7:58 PM UTC

The "cron" time is around 00:00 UTC at the moment.

For example:

1ef43f9

new Date('April 25, 2023 08:07:53 GMT+8').toUTCString()
"Tue, 25 Apr 2023 00:07:53 GMT" 
// "Tue, 25 Apr 2023 00:07:53 GMT" 

@techknowlogick
Copy link
Member Author

The "cron" time is around 00:00 UTC at the moment.

yup, you're right. my timezone math was off. I've updated to use close to midnight UTC.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@techknowlogick techknowlogick merged commit 61a73ed into go-gitea:main Apr 26, 2023
@techknowlogick techknowlogick deleted the actions-cron branch April 26, 2023 01:32
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2023
* giteaofficial/main:
  Fix broken clone script on an empty archived repo (go-gitea#24339)
  Improve RSS (go-gitea#24335)
  Automatically select the org when click create repo from org dashboard (go-gitea#24325)
  on schedule
  on schedule
  switch to use Actions from drone for cron (go-gitea#24314)
  [skip ci] Updated translations via Crowdin
  Restore bold on repolist (go-gitea#24337)
  Fix template function DateTime (go-gitea#24317)
  Fix incorrect CORS response in Http Git handler (go-gitea#24303)
  Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260)
  Add tags list for repos whose release setting is disabled (go-gitea#23465)
  Refactor config provider (go-gitea#24245)
  Add RSS Feeds for branches and files (go-gitea#22719)
  Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316)
  Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
@wolfogre
Copy link
Member

wolfogre commented Apr 27, 2023

Something surprised me: once I sync this PR commit to my fork, the cron task will be triggered in my fork repo.

See https://github.com/wolfogre/gitea/actions/workflows/cron-translations.yml

It doesn't really hurt but it's annoying:

  • It will waste my free actions hours.
  • I will receive error messages about the failed jobs.

However, the good news is that I can disable the workflow manually.

image

@wxiaoguang
Copy link
Contributor

I also see this behavior.

image

techknowlogick added a commit that referenced this pull request Apr 30, 2023
similar to #24314, this moves drone cron pipelines to (GitHub) Actions.
As these are mostly compatible with Gitea Actions, when we start to
dogfood, these will already be migrated.

I also removed the discord notify pipeline, as it hasn't been working
for several months.
techknowlogick added a commit that referenced this pull request May 4, 2023
following #24314 and
#24434, this PR moves drone cron
pipelines to (GitHub) Actions. As these are mostly compatible with Gitea
Actions, when we start to dogfood, these will already be migrated.

---------

Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants